Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AspectRatio): extend props from RootComponent #7148

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

BlackySoul
Copy link
Contributor


Изменения

Расширяем компонент всеми пропами от RootComponent

@BlackySoul BlackySoul requested a review from a team as a code owner July 8, 2024 09:30
@BlackySoul BlackySoul linked an issue Jul 8, 2024 that may be closed by this pull request
SevereCloud
SevereCloud previously approved these changes Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

size-limit report 📦

Path Size
JS 372.64 KB (0%)
JS (gzip) 114.04 KB (0%)
JS (brotli) 93.89 KB (0%)
JS import Div (tree shaking) 1.42 KB (0%)
CSS 300.04 KB (0%)
CSS (gzip) 38.28 KB (0%)
CSS (brotli) 30.83 KB (0%)

Copy link

codesandbox-ci bot commented Jul 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jul 8, 2024

👀 Docs deployed

Commit fb191a3

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (9956fbb) to head (fb191a3).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7148      +/-   ##
==========================================
+ Coverage   83.92%   84.10%   +0.18%     
==========================================
  Files         357      357              
  Lines       10785    10882      +97     
  Branches     3558     3589      +31     
==========================================
+ Hits         9051     9152     +101     
+ Misses       1734     1730       -4     
Flag Coverage Δ
unittests 84.10% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon previously approved these changes Jul 15, 2024
@BlackySoul BlackySoul merged commit f6a2929 into master Jul 15, 2024
26 checks passed
@BlackySoul BlackySoul deleted the feat/7145/AspectRatio_extend_Root branch July 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][AspectRatio]: Добавить Component проп
3 participants