feat(RichCell): add prop afterAlign #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 0b6d36b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7192 +/- ##
==========================================
+ Coverage 92.51% 92.54% +0.02%
==========================================
Files 374 374
Lines 11109 11115 +6
Branches 3640 3643 +3
==========================================
+ Hits 10278 10286 +8
+ Misses 831 829 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vkcom-publisher
added
pr-needs-work
vkcom-publisher
added
the
pr-needs-work
EldarMuhamethanov
removed
the
pr-needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавить возможность выравнивания
afterкомпонента по вертикали в компонентеRichCellИзменения
RichCell, вынесafterкомпонента из блокаRichCell__content.afterAlign, с помощью которого можно менять выравнивание компонента по вертикалиUPD
Согласовал с дизайном следующее поведение:
Если передан
afterAlign: 'start'рендеримafterкак раньше.Если передан другой
afterAlign, то рендерим в другом контейнере, чтобы можно было выравнять по вертикали