Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Header): add props before, beforeTitle, afterTitle, beforeSubtitle, afterSubtitle #7202

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


  • e2e-тесты
  • Документация фичи

Описание

Нужно добавить недостающие параметры для компонента Header

Изменения

  • Добавил пропс before для отображения иконки слева от контента
  • Добавил пропс beforeTitle для отображения иконки слева от заголовка
  • Добавил пропс afterTitle для отображения иконки справа от заголовка
  • Добавил пропс beforeSubtitle для отображения иконки слева от подзаголовка
  • Добавил пропс afterSubtitle для отображения иконки справа от подзаголовка
  • Добавил новые состояния в скриншотные тесты
  • Добавил примеры использования в документацию
  • Добавил story в storybook с новыми фичами

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner July 16, 2024 15:20
Copy link
Contributor

github-actions bot commented Jul 16, 2024

size-limit report 📦

Path Size
JS 379.16 KB (+0.16% 🔺)
JS (gzip) 114.94 KB (+0.11% 🔺)
JS (brotli) 94.36 KB (+0.21% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 307.55 KB (+0.26% 🔺)
CSS (gzip) 39.45 KB (+0.23% 🔺)
CSS (brotli) 31.65 KB (+0.3% 🔺)

Copy link

codesandbox-ci bot commented Jul 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jul 16, 2024

👀 Docs deployed

Commit 5bed5d3

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.45%. Comparing base (a1dd8c8) to head (5bed5d3).
Report is 1 commits behind head on master.

Files Patch % Lines
packages/vkui/src/components/Header/Header.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7202      +/-   ##
==========================================
- Coverage   94.46%   94.45%   -0.01%     
==========================================
  Files         375      375              
  Lines       11162    11168       +6     
  Branches     3664     3670       +6     
==========================================
+ Hits        10544    10549       +5     
- Misses        618      619       +1     
Flag Coverage Δ
unittests 94.45% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Jul 17, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Шикарно! 🥇

mendrew
mendrew previously approved these changes Jul 18, 2024
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jul 26, 2024
@inomdzhon inomdzhon marked this pull request as draft July 30, 2024 12:09
@inomdzhon
Copy link
Contributor

пока перевёл в черновик, т.к. нам нужно определится с before/after или start/end

@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Aug 7, 2024
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Aug 15, 2024
# Conflicts:
#	packages/vkui/src/components/Header/Header.stories.tsx
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review August 27, 2024 07:30
@inomdzhon inomdzhon merged commit d491080 into master Aug 27, 2024
33 of 52 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/6104/update-header-props branch August 27, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Header]: Не реализованы некоторые стейты из ДС
5 participants