-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Header): add props before, beforeTitle, afterTitle, beforeSubtitle, afterSubtitle #7202
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 5bed5d3 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7202 +/- ##
==========================================
- Coverage 94.46% 94.45% -0.01%
==========================================
Files 375 375
Lines 11162 11168 +6
Branches 3664 3670 +6
==========================================
+ Hits 10544 10549 +5
- Misses 618 619 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Шикарно! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
пока перевёл в черновик, т.к. нам нужно определится с |
# Conflicts: # packages/vkui/src/components/Header/Header.stories.tsx
Описание
Нужно добавить недостающие параметры для компонента
Header
Изменения
before
для отображения иконки слева от контентаbeforeTitle
для отображения иконки слева от заголовкаafterTitle
для отображения иконки справа от заголовкаbeforeSubtitle
для отображения иконки слева от подзаголовкаafterSubtitle
для отображения иконки справа от подзаголовкаstory
вstorybook
с новыми фичами