fix(ActionSheetItem): fix navigation by arrows in selectable ActionSheetItem #7216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit a2d29e5 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7216 +/- ##
==========================================
+ Coverage 84.07% 84.08% +0.01%
==========================================
Files 361 362 +1
Lines 10937 10953 +16
Branches 3600 3605 +5
==========================================
+ Hits 9195 9210 +15
- Misses 1742 1743 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vkcom-publisher
added
the
pr-needs-work
inomdzhon
removed
the
patch
inomdzhon
deleted the
e.muhamethanov/6954/selectable-items-navigation-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
При навигации с помощью стрелочек по
ActionSheetItemsсselectableфлагом закрываетсяActionSheetИзменения
clickпри навигации по элементам. Нашел вариант как можно ее обойти Bug: onClick firing when radio button is selcted with arrow keys facebook/react#7407. С помощью проверки можно отличить реальное событие клика.Enter, при котором происходит закрытиеActionSheet