-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FocusTrap): add autoFocus to root possibility #7302
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit fe87650 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7302 +/- ##
==========================================
- Coverage 83.47% 83.45% -0.02%
==========================================
Files 370 369 -1
Lines 11181 11178 -3
Branches 3658 3659 +1
==========================================
- Hits 9333 9329 -4
- Misses 1848 1849 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здорово!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Описание
Нужно добавить возможность фокуса на контейнер FocusTrap при первой отрисовке
Изменения
Добавил в пропс
autoFocus
значение 'root' и использовал его при первой отрисовке, чтобы сфокусироваться на контейнере. Добавил тест проверяющий новый функционал