-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ModalRoot): improve unit-tests coverage #7344
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 83aa606 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7344 +/- ##
==========================================
+ Coverage 92.51% 93.96% +1.44%
==========================================
Files 374 374
Lines 11109 11126 +17
Branches 3640 3646 +6
==========================================
+ Hits 10278 10455 +177
+ Misses 831 671 -160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💠
packages/vkui/src/components/ModalRoot/ModalRootAdaptive.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrey Medvedev <andr.medv.spb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Добавил milestone
✅ v6.6.0 🎉 |
Описание
Улучшил покрытие тестами компонента ModalRoot