Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ModalRoot): improve unit-tests coverage #7344

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты

Описание

Улучшил покрытие тестами компонента ModalRoot

Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
JS 378.05 KB (-0.01% 🔽)
JS (gzip) 114.66 KB (+0.02% 🔺)
JS (brotli) 94.21 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.39 KB (0%)
CSS 305.67 KB (0%)
CSS (gzip) 39.22 KB (0%)
CSS (brotli) 31.48 KB (0%)

Copy link

codesandbox-ci bot commented Aug 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👀 Docs deployed

Commit 83aa606

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (58e02bf) to head (83aa606).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7344      +/-   ##
==========================================
+ Coverage   92.51%   93.96%   +1.44%     
==========================================
  Files         374      374              
  Lines       11109    11126      +17     
  Branches     3640     3646       +6     
==========================================
+ Hits        10278    10455     +177     
+ Misses        831      671     -160     
Flag Coverage Δ
unittests 93.96% <100.00%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💠

EldarMuhamethanov and others added 2 commits August 13, 2024 12:54
Co-authored-by: Andrey Medvedev <andr.medv.spb@gmail.com>
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Добавил milestone

@inomdzhon inomdzhon added this to the v6.6.0 milestone Aug 20, 2024
@inomdzhon inomdzhon merged commit 6c97fc6 into master Aug 20, 2024
27 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/tests-coverage/modal-root branch August 20, 2024 08:26
@vkcom-publisher
Copy link
Contributor

v6.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants