fix(Flex): add margin auto offset #7426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit c198ef0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7426 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 375 375
Lines 11133 11133
Branches 3650 3650
=======================================
Hits 10519 10519
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
approved these changes
Aug 22, 2024
inomdzhon
approved these changes
Aug 22, 2024
SevereCloud
approved these changes
Aug 26, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Aug 26, 2024
* fix(Flex): margin auto offset * CHORE: Update screenshots --------- Co-authored-by: GitHub Action <actions@github.com>
| ✅ v6.5.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Из-за того, что по умолчанию
--vkui_internal--row_gapи--vkui_internal--column_gapустанавливались в0, то при их участии в расчете черезcalcсвойствоmarginрассчитывалось неверно (отсутствовали отступы сверху-слева)Изменения
Инициализируем значения как
0px