Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChipsSelect): add close dropdown when click dropdown icon #7462

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Дизайн-ревью

Описание

Нужно реализовать закрытие дропдауна в компоненте ChipsSelect при нажатии на DropdownIcon

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner August 27, 2024 11:34
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 27, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 379.29 KB (+0.04% 🔺)
JS (gzip) 114.97 KB (+0.03% 🔺)
JS (brotli) 94.35 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 307.61 KB (+0.02% 🔺)
CSS (gzip) 39.46 KB (+0.04% 🔺)
CSS (brotli) 31.64 KB (-0.01% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 714a806

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (d491080) to head (714a806).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7462   +/-   ##
=======================================
  Coverage   94.45%   94.46%           
=======================================
  Files         375      375           
  Lines       11168    11175    +7     
  Branches     3670     3673    +3     
=======================================
+ Hits        10549    10556    +7     
  Misses        619      619           
Flag Coverage Δ
unittests 94.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon removed the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Aug 28, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@inomdzhon
Copy link
Contributor

inomdzhon commented Aug 28, 2024

Note

удалил лейбел patch, т.к. изменения попадут в v6.6.0

@inomdzhon inomdzhon merged commit 46a43bc into master Aug 28, 2024
28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/7458/close-select-by-click-arrow branch August 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Закрывать ChipsSelect по клику на стрелочку
3 participants