fix(CustomScrollView): rm mutation props #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 39aacc7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7479 +/- ##
==========================================
- Coverage 95.03% 95.01% -0.02%
==========================================
Files 375 375
Lines 11178 11144 -34
Branches 3674 3655 -19
==========================================
- Hits 10623 10589 -34
Misses 555 555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- see #6920 --- > Mutating component props or hook arguments is not allowed Убираем мутации пропов, так как это не поддерживается реакт компилятором
SevereCloud
force-pushed
the
SevereCloud/fix/CustomScrollView/rm-mutation-props
branch
from
00f1458
to
f39e21b
Compare
BlackySoul
approved these changes
Aug 30, 2024
inomdzhon
approved these changes
Aug 30, 2024
inomdzhon
deleted the
SevereCloud/fix/CustomScrollView/rm-mutation-props
branch
| ✅ v6.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Убираем мутации пропов, так как это не поддерживается реакт компилятором