-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ScreenSpinner): add overlay mode #7484
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 86ecd4a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7484 +/- ##
==========================================
+ Coverage 95.02% 95.05% +0.02%
==========================================
Files 378 382 +4
Lines 11206 11213 +7
Branches 3674 3675 +1
==========================================
+ Hits 10649 10658 +9
+ Misses 557 555 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ ✨ ✨
✨ 🔄 ✨
✨ ✨ ✨
408a212
86ecd4a
Изменения
mode
, который отвечает за режим отображенияmode=shadow
в соответствии с ДСnoColor
Пришлось
немного перетрясти структуру - стайлгайдист не смог смапить названиеScreenSpinner
:Поэтому все подкомпоненты вынесла в отдельные файлы