Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ScreenSpinner): add overlay mode #7484

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Aug 30, 2024


  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Изменения

  • добавлен проп mode, который отвечает за режим отображения
  • исправлен токен для тени в режиме mode=shadow в соответствии с ДС
  • иногда цвет спиннера должен переопределяться контекстом сверху, для этого завела проп noColor
  • объединила скриншотные тесты

Пришлось немного перетрясти структуру - стайлгайдист не смог смапить название ScreenSpinner:

image

Поэтому все подкомпоненты вынесла в отдельные файлы

@BlackySoul BlackySoul requested a review from a team as a code owner August 30, 2024 08:00
@BlackySoul BlackySoul linked an issue Aug 30, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Aug 30, 2024

size-limit report 📦

Path Size
JS 380.71 KB (+0.07% 🔺)
JS (gzip) 115.27 KB (+0.08% 🔺)
JS (brotli) 94.6 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.06 KB (+0.06% 🔺)
CSS (gzip) 39.64 KB (+0.07% 🔺)
CSS (brotli) 31.86 KB (+0.25% 🔺)

Copy link

codesandbox-ci bot commented Aug 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Aug 30, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Aug 30, 2024

👀 Docs deployed

Commit 86ecd4a

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.05%. Comparing base (bbd6c3b) to head (86ecd4a).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...components/ScreenSpinner/ScreenSpinnerSwapIcon.tsx 80.95% 4 Missing ⚠️
...omponents/ScreenSpinner/ScreenSpinnerContainer.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7484      +/-   ##
==========================================
+ Coverage   95.02%   95.05%   +0.02%     
==========================================
  Files         378      382       +4     
  Lines       11206    11213       +7     
  Branches     3674     3675       +1     
==========================================
+ Hits        10649    10658       +9     
+ Misses        557      555       -2     
Flag Coverage Δ
unittests 95.05% <89.79%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

inomdzhon
inomdzhon previously approved these changes Aug 30, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ ✨
✨ 🔄 ✨
✨ ✨ ✨

inomdzhon
inomdzhon previously approved these changes Aug 30, 2024
@BlackySoul BlackySoul requested a review from a team August 30, 2024 12:58
@SevereCloud SevereCloud requested a review from inomdzhon August 30, 2024 15:02
@BlackySoul BlackySoul merged commit 46e2c13 into master Sep 2, 2024
27 of 28 checks passed
@BlackySoul BlackySoul deleted the feat/6952/ScreenSpinner_add_overlay branch September 2, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][ScreenSpinner]: Поддержать overlay режим
3 participants