Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(useScrollLockEffect): rm death code #7490

Merged

Conversation

SevereCloud
Copy link
Contributor


Удаляем неиспользуемый код, который мешает react компилятору

- see #6920

Удаляем неиспользуемый код, который мешает react компилятору
@SevereCloud SevereCloud requested a review from a team as a code owner August 30, 2024 14:37
Copy link
Contributor

size-limit report 📦

Path Size
JS 380.48 KB (0%)
JS (gzip) 115.18 KB (0%)
JS (brotli) 94.57 KB (0%)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 308.88 KB (0%)
CSS (gzip) 39.62 KB (0%)
CSS (brotli) 31.78 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit f31aa1e

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (fd2af58) to head (f31aa1e).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7490      +/-   ##
==========================================
+ Coverage   95.03%   95.16%   +0.12%     
==========================================
  Files         380      380              
  Lines       11216    11200      -16     
  Branches     3674     3671       -3     
==========================================
- Hits        10659    10658       -1     
+ Misses        557      542      -15     
Flag Coverage Δ
unittests 95.16% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud self-assigned this Aug 30, 2024
@SevereCloud SevereCloud merged commit 8165dc9 into master Sep 2, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/chore/useScrollLockEffect/rm-death-code branch September 2, 2024 06:10
@SevereCloud SevereCloud added this to the v6.6.0 milestone Sep 2, 2024
@vkcom-publisher
Copy link
Contributor

v6.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants