feat(ScreenSpinner): add caption prop #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 5d56350 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7505 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 384 384
Lines 11267 11274 +7
Branches 3693 3696 +3
=======================================
+ Hits 10721 10728 +7
Misses 546 546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
force-pushed
the
feat/6267/ScreenSpinner_add_sibtitle
branch
from
c05c816
to
9e4a0f5
Compare
SevereCloud
previously approved these changes
Sep 9, 2024
inomdzhon
reviewed
Sep 9, 2024
BlackySoul
dismissed stale reviews from Zaycevq, SevereCloud, and andrey-medvedev-vk
via
e21035f
inomdzhon
reviewed
Sep 11, 2024
packages/vkui/src/components/ScreenSpinner/ScreenSpinnerLoader.tsx
Outdated
Show resolved
Hide resolved
BlackySoul
force-pushed
the
feat/6267/ScreenSpinner_add_sibtitle
branch
from
e21035f
to
566cc1b
Compare
BlackySoul
changed the title
inomdzhon
approved these changes
Sep 11, 2024
SevereCloud
approved these changes
Sep 11, 2024
1 task
inomdzhon
pushed a commit
that referenced
this pull request
Oct 24, 2024
h2. Описание Убираем текст по умолчанию, как договорились в [обсуждении](#7505 (comment)) h2. Release notes h2. BREAKING CHANGE - ScreenSpinner: удалён `a11y`-текст по умолчанию, передавайте нужный текст в `children` или `label` свойства.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавить возможность прокидывать текст в
ScreenSpinnerRelease notes
Улучшения
ScreenSpinner: добавлена возможность прокидывать
caption