-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y(Card): change default tags to components Card, CardGrid, CardScroll, ContentCard #7520
a11y(Card): change default tags to components Card, CardGrid, CardScroll, ContentCard #7520
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 5e6e72b |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7520 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 384 384
Lines 11345 11345
Branches 3720 3720
=======================================
Hits 10802 10802
Misses 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Классно!
Я бы ещё предложил пройтись по страницам компонентов в доке и чуть текст поменять, явно говоря в секции по a11y, что у нас по умолчанию уже такие теги используются.
Чтобы пользвателям не надо было лезть в пропсы и искать значение по умолчанию там, после того, как валидатор html выдаст ошибку, что внезапно где-то есть тег li без ul.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
Описание
Нужно заменить теги по умолчанию для рендеринга компонентов Card, CardGrid, CardScroll, ContentCard на семантические
Изменения
Заменил теги по умолчанию у компонентов Card, CardGrid, CardScroll, ContentCard на
ul
илиli
Release notes
BREAKING CHANGE
div
наli
div
наli
div
наul
div
наul