Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalRoot): call onClosed only once #7543

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

BlackySoul
Copy link
Contributor


  • Release notes

Описание

За счет бабблинга событий transitionend на родительском элементе может вызываться несколько раз

Изменения

  • проверяем на целевой элемент, для которого нам интересно завершение анимации
  • немного изменяем типы

Release notes

Исправления

  • ModalRoot: исправлены повторные вызовы onClosed при определенных условиях

@BlackySoul BlackySoul requested a review from a team as a code owner September 9, 2024 10:26
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size
JS 381.21 KB (+0.02% 🔺)
JS (gzip) 115.41 KB (+0.02% 🔺)
JS (brotli) 94.82 KB (+0.11% 🔺)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 309.36 KB (0%)
CSS (gzip) 39.68 KB (0%)
CSS (brotli) 31.86 KB (0%)

Copy link

codesandbox-ci bot commented Sep 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 9, 2024

👀 Docs deployed

Commit 88ce56f

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (92a647a) to head (88ce56f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...vkui/src/components/ModalRoot/ModalRootDesktop.tsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7543      +/-   ##
==========================================
- Coverage   95.18%   95.16%   -0.02%     
==========================================
  Files         384      384              
  Lines       11226    11232       +6     
  Branches     3683     3685       +2     
==========================================
+ Hits        10685    10689       +4     
- Misses        541      543       +2     
Flag Coverage Δ
unittests 95.16% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit fa216af into master Sep 9, 2024
26 of 28 checks passed
@BlackySoul BlackySoul deleted the fix/7525/ModalPage_fix_onClosed branch September 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
3 participants