Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ImageBaseOverlay): remove disableInteractive prop #7628

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 19, 2024


  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Сейчас у компонента ImageBaseOverlay есть проп disableInteractive. Он отключает интерактивность самого компонента Overlay. Нужно избавиться от этого пропа и вместо него использовать переданное значение onClick в компонент. Если передано, то disableInteractive=false, если нет, то disableInteractive=true.

Изменения

  • Удалил проп disableInteractive
  • Поправил места использования в коде
  • Поправил тесты
  • Реализовал кодмод для правильного обновления. Также в кодмоде, те кейсы, которые нельзя обработать точно правильно, добавил вывод сообщения в консоль

Release notes

BREAKING CHANGE

  • Image: у сабкомпонента Image.Overlay параметр disableInteractive был удален, вместо него теперь можно просто не прокидывать параметр onClick

Copy link
Contributor

github-actions bot commented Sep 19, 2024

size-limit report 📦

Path Size
JS 385.12 KB (-0.03% 🔽)
JS (gzip) 116.46 KB (-0.02% 🔽)
JS (brotli) 95.61 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.12 KB (0%)
CSS (gzip) 41.3 KB (0%)
CSS (brotli) 32.74 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 19, 2024

👀 Docs deployed

Commit 7d61909

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (b85d3da) to head (8ebb07c).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7628      +/-   ##
==========================================
- Coverage   95.21%   95.14%   -0.07%     
==========================================
  Files         384      383       -1     
  Lines       11360    11349      -11     
  Branches     3728     3729       +1     
==========================================
- Hits        10816    10798      -18     
- Misses        544      551       +7     
Flag Coverage Δ
unittests 95.14% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codmods master! 💯

Единственное, на что хочу обратить внимание, это сообщение для пользователя. Хорошо бы сделать их более понятными, расписать причины.
Ясно, что можно в migration guide залезть, но проще понять что не так, когда есть контекст.

В паре мест я предложил что можно написать, но пару последних опустил, там тоже надо бы поподробнее причину описать.

packages/codemods/src/transforms/v7/image-overlay.ts Outdated Show resolved Hide resolved
packages/codemods/src/transforms/v7/image-overlay.ts Outdated Show resolved Hide resolved
packages/codemods/src/transforms/v7/image-overlay.ts Outdated Show resolved Hide resolved
packages/codemods/src/transforms/v7/image-overlay.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 🔥

@EldarMuhamethanov EldarMuhamethanov merged commit 9ac63e2 into master Sep 25, 2024
25 of 26 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/remove-disable-interactive branch September 25, 2024 10:03
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.0 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.0, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants