Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: pr7235 (#7619) #7656

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

SevereCloud
Copy link
Contributor

This reverts commit dd77217.

This reverts commit 13258fe.

* Revert "fix(CustomSelect): fix custom select cursor updating (#7508)"

This reverts commit dd77217.

* Revert "fix(CustomSelect): a11y allow NVDA to read selected option (#7235)"

This reverts commit 13258fe.
@SevereCloud SevereCloud requested a review from a team as a code owner September 24, 2024 12:34
Copy link
Contributor

size-limit report 📦

Path Size
JS 377.67 KB (-0.07% 🔽)
JS (gzip) 114.5 KB (-0.07% 🔽)
JS (brotli) 93.95 KB (-0.08% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 306.35 KB (-0.16% 🔽)
CSS (gzip) 39.3 KB (-0.14% 🔽)
CSS (brotli) 31.56 KB (-0.09% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 2fe7737

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (ac31671) to head (2fe7737).
Report is 1 commits behind head on 6.5-stable.

Files with missing lines Patch % Lines
.../vkui/src/components/CustomSelect/CustomSelect.tsx 90.24% 4 Missing ⚠️
.../src/components/CustomSelect/CustomSelectInput.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           6.5-stable    #7656      +/-   ##
==============================================
- Coverage       84.14%   84.11%   -0.03%     
==============================================
  Files             375      374       -1     
  Lines           11112    11101      -11     
  Branches         3645     3646       +1     
==============================================
- Hits             9350     9338      -12     
- Misses           1762     1763       +1     
Flag Coverage Δ
unittests 84.11% <91.07%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit bcc3811 into 6.5-stable Sep 24, 2024
25 of 26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/revert/6.5-pr7235 branch September 24, 2024 13:32
@SevereCloud SevereCloud added this to the v6.5.4 milestone Sep 24, 2024
@vkcom-publisher
Copy link
Contributor

v6.5.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants