Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CellButton): mv mode to appearance #7684

Merged

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Sep 30, 2024


  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Дизайн-ревью
  • Codemode
  • Release notes

Описание

см. #7683

Release notes

BREAKING CHANGE

  • CellButton: свойство mode заменено на appearance со значениями 'accent' | 'neutral' | 'negative', также для appearance="accent" (a.k.a mode="primary") возвращён токен --vkui--color_text_accent, а вот при комбинации с centered применяется --vkui--color_text_accent_themed
    <CellButton
    -  mode="danger"
    +  appearance="negative"
    >
      Создать что-нибудь
    </CellButton>
    
    <CellButton
    -  mode="primary"
    +  appearance="accent"
    >
      Создать что-нибудь
    </CellButton>

Copy link
Contributor

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size
JS 385.7 KB (+0.03% 🔺)
JS (gzip) 116.71 KB (+0.03% 🔺)
JS (brotli) 95.87 KB (-0.04% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.75 KB (+0.09% 🔺)
CSS (gzip) 41.58 KB (+0.06% 🔺)
CSS (brotli) 32.93 KB (-0.11% 🔽)

Copy link

codesandbox-ci bot commented Sep 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 30, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 30, 2024

👀 Docs deployed

Commit 0bc844a

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (5459b15) to head (0bc844a).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7684      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.02%     
==========================================
  Files         383      383              
  Lines       11335    11348      +13     
  Branches     3714     3719       +5     
==========================================
+ Hits        10787    10798      +11     
- Misses        548      550       +2     
Flag Coverage Δ
unittests 95.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon marked this pull request as ready for review October 1, 2024 10:09
@inomdzhon inomdzhon requested a review from a team as a code owner October 1, 2024 10:09
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@qurle qurle requested a review from a team October 1, 2024 10:44
Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за вашу работу

@inomdzhon inomdzhon merged commit ebd2f26 into master Oct 1, 2024
52 of 53 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/issues7683/feat/CellButton-appearance branch October 1, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Cell Button]: Покрасить CellButton в Accent
4 participants