-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Separator): add direction, size, padding and align props #7720
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests
|
👀 Docs deployed
Commit 0fbbfb8 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7720 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 383 384 +1
Lines 11343 11355 +12
Branches 3718 3725 +7
=======================================
+ Hits 10792 10804 +12
Misses 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1773eca
to
4dfb2f5
Compare
packages/vkui/src/components/Spacing/Spacing.e2e-playground.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨✨✨
✨💖✨
✨✨✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Шикарно 💯 🥇
В #7767 значения |
Описание
Синхронизируемся с дизайном в плане пропов
Изменения
.withGaps > *
воFlex
был утяжелен, потому что мы задаем некоторым компонентамmargin
, а значение уFlex
должно быть приоритетнымSpacing
иSeparator
Release notes
BREAKING CHANGE
Separator: свойство
wide
заменено свойствомpadding
Улучшения
Note
UPD см. #7720 (comment)
direction
,size
иalign