Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): import Tappable.module.css #7734

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 10, 2024

Описание

Из-за неверного порядка css в cssm сборке <Button loading/> становится высоким

image

Изменения

Добавили импорт Tappable.module.css чтобы изменить порядок css

Release notes

Исправления

  • Button: loading неверно отображался в cssm сборке

@SevereCloud SevereCloud requested a review from a team as a code owner October 10, 2024 13:49
@SevereCloud SevereCloud self-assigned this Oct 10, 2024
@SevereCloud SevereCloud added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v6 Автоматизация: PR продублируется в ветку v6 type:bug cmp:button labels Oct 10, 2024
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 385.75 KB (0%)
JS (gzip) 116.74 KB (0%)
JS (brotli) 95.96 KB (0%)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.77 KB (0%)
CSS (gzip) 41.58 KB (0%)
CSS (brotli) 32.95 KB (0%)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit d08129e

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (aa96eb1) to head (d08129e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7734   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         383      383           
  Lines       11343    11343           
  Branches     3718     3718           
=======================================
  Hits        10792    10792           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud merged commit fcf6f8e into master Oct 10, 2024
28 checks passed
@SevereCloud SevereCloud deleted the dsuvorov/fix/Button/import-Tappable.module.css branch October 10, 2024 14:03
@vkcom-publisher
Copy link
Contributor

❌ Patch

Не удалось автоматически применить исправление на ветке 7.0-stable.

Дальнейшие действия выполняют контрибьютеры из группы @VKCOM/vkui-core

Чтобы изменение попало в ветку 7.0-stable, выполните следующие действия:

  1. Создайте новую ветку от 7.0-stable и примените изменения используя cherry-pick
git stash # опционально
git fetch origin 7.0-stable
git checkout -b patch/pr7734 origin/7.0-stable

git cherry-pick --no-commit fcf6f8e3f56ccbe5eed81dc84c89019a99047abf
git checkout HEAD **/__image_snapshots__/*.png
git diff --quiet HEAD || git commit --no-verify --no-edit
  1. Исправьте конфликты, следуя инструкциям из терминала
  2. Отправьте ветку на GitHub и создайте новый PR с веткой 7.0-stable (установка лейбла не требуется!)
git push --set-upstream origin patch/pr7734
gh pr create --base 7.0-stable --title "patch: pr7734" --body "- patch #7734"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:button patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug v6 Автоматизация: PR продублируется в ветку v6
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants