Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CardScroll): rename prop noSpaces to padding #7788

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

В компоненте CardScroll заменил свойство noSpaces на padding с противоположным значением. При этом по умолчанию padding = false. Поэтому кодмоды были реализованы с учетом этого.

Release notes

BREAKING CHANGE

  • CardScroll: свойство noSpaces заменено на padding
    <CardScroll
      size="s"
    - noSpaces
    + padding={false}
    >
      <Card>
        <div style={{ paddingBottom: '66%' }} />
      </Card>
    </CardScroll>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 18, 2024 07:46
Copy link
Contributor

size-limit report 📦

Path Size
JS 386.56 KB (-0.01% 🔽)
JS (gzip) 116.92 KB (-0.01% 🔽)
JS (brotli) 96.03 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.56 KB (+0.01% 🔺)
CSS (gzip) 41.81 KB (+0.01% 🔺)
CSS (brotli) 33.11 KB (+0.12% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 63ad2a6

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (975878d) to head (63ad2a6).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7788   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11354    11357    +3     
  Branches     3724     3727    +3     
=======================================
+ Hits        10803    10806    +3     
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 98faaac into master Oct 21, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7756/card-scroll-rename-nospace-padding branch October 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] CardScroll: переименовать noSpaces -> padding
4 participants