Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CardGrid): rename props spaced to padding #7804

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

Рассмотрел возможность замены CardGrid на SimpleGrid. В целом такое возможно, но у CardGrid при использовании с Group добавляются дополнительные отступы. Также в SimpleGrid необходимо прокидывать нужное количество столбцов, что тоже немного неудобно. В общем, решил пока не депрекейтить компонент и переименовал свойство spaced на padding. Тем более задепрекейтить компонент можно и в минорной версии.

Release notes

BREAKING CHANGE

  • CardGrid: свойство spaced переименовано на padding
    <CardGrid
      size="s"
    - spaced
    + padding
    >
      <Card>
        <div style={{ paddingBottom: '66%' }} />
      </Card>
    </CardGrid>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 21, 2024 16:52
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 21, 2024

👀 Docs deployed

Commit daec1b4

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (1d408a5) to head (daec1b4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7804   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11357    11357           
  Branches     3727     3727           
=======================================
  Hits        10806    10806           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

size-limit report 📦

Path Size
JS 386.65 KB (+0.01% 🔺)
JS (gzip) 116.88 KB (-0.01% 🔽)
JS (brotli) 95.94 KB (-0.07% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.75 KB (+0.01% 🔺)
CSS (gzip) 41.82 KB (-0.01% 🔽)
CSS (brotli) 33.1 KB (-0.06% 🔽)

@EldarMuhamethanov EldarMuhamethanov merged commit d735ce1 into master Oct 22, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7803/card-grid-rename-spaced-to-padding branch October 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants