Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DateInput, DateRangeInput): add prop onCalendarOpenChanged #7878

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat(DateInput, DateRangeInput): add prop onCalendarOpenChanged #7878

merged 2 commits into from
Nov 5, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Nov 1, 2024 •
edited
Loading

  • Unit-тесты
  • Release notes

Описание

Нужно для компонентов DateInput, DateRangeInput добавить свойство onCalendarOpenChanged колбэк, который будет срабатывать при изменении состояния открытости календаря

Изменения

Добавил свойство onCalendarOpenChanged для компонентов DateInput, DateRangeInput

Release notes

Улучшения

  • DateInput: добавлено свойство onCalendarOpenChanged - колбэк, срабатывающий при открытии/закрытии календаря
  • DateRangeInput: добавлено свойство onCalendarOpenChanged - колбэк, срабатывающий при открытии/закрытии календаря

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 1, 2024 12:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 382.71 KB (+0.08% 🔺)
JS (gzip) 122.48 KB (+0.09% 🔺)
JS (brotli) 101.45 KB (+0.11% 🔺)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 1, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

👀 Docs deployed

Commit 685009d

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (ebb46a5) to head (685009d).
Report is 13 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7878      +/-   ##
==========================================
+ Coverage   95.17%   95.18%   +0.01%     
==========================================
  Files         376      376              
  Lines       11041    11049       +8     
  Branches     3664     3668       +4     
==========================================
+ Hits        10508    10517       +9     
+ Misses        533      532       -1
Flag Coverage Δ
unittests 95.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft November 1, 2024 15:03
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review November 1, 2024 15:28
@EldarMuhamethanov EldarMuhamethanov changed the title feat(DateInput, DateRangeInput): add prop onCalendarClose feat(DateInput, DateRangeInput): add prop onCalendarOpenChanged Nov 2, 2024
@andrey-medvedev-vk andrey-medvedev-vk added the v6 Автоматизация: PR продублируется в ветку v6 label Nov 2, 2024
andrey-medvedev-vk
andrey-medvedev-vk approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 👏 👏 👏

Черри-пикнешь в 6.7-stable, пожалуйста, после мержа?

inomdzhon
inomdzhon approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в Release notes надо поправить заголовок BREAKING CHANGE на Улучшения, т.к. не вижу, чтобы это было ломающее изменение

@EldarMuhamethanov EldarMuhamethanov merged commit be68ee8 into master Nov 5, 2024
34 of 52 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7865/onCalendarClose-prop-DateInput branch November 5, 2024 09:08
vkcom-publisher pushed a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov @actions-user
feat(DateInput, DateRangeInput): add prop onCalendarOpenChanged (#7878
badc56d 
)

* feat(DateInput, DateRangeInput): add prop onCalendarClose

* feat(DateInput): replace onCalendarClose to onCalendarOpenChanged
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
feat(DateInput, DateRangeInput): add prop onCalendarOpenChanged (#7878
5363531 
)

* feat(DateInput, DateRangeInput): add prop onCalendarClose

* feat(DateInput): replace onCalendarClose to onCalendarOpenChanged

(cherry picked from commit be68ee8)
@EldarMuhamethanov EldarMuhamethanov mentioned this pull request Nov 5, 2024
Merged
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
patch: pr7878 (#7896)
af6aa97 
* feat(DateInput, DateRangeInput): add prop `onCalendarOpenChanged` (#7878)

* feat(DateInput, DateRangeInput): add prop onCalendarClose

* feat(DateInput): replace onCalendarClose to onCalendarOpenChanged

(cherry picked from commit be68ee8)

* test(DateRangeInput): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees
No one assigned
Labels
v6 Автоматизация: PR продублируется в ветку v6
Projects
None yet
Milestone
No milestone
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk