Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FocusTrap): mv to hook #7879

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

inomdzhon
Copy link
Contributor


Описание

Код FocusTrap вынесен в useFocusTrap, чтобы была возможность использовать его со своим DOM элементом.

Release notes

@inomdzhon inomdzhon self-assigned this Nov 1, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner November 1, 2024 13:21
Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size
JS 382.59 KB (+0.05% 🔺)
JS (gzip) 122.41 KB (+0.03% 🔺)
JS (brotli) 101.41 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link

codesandbox-ci bot commented Nov 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👀 Docs deployed

Commit 2642f97

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (ebb46a5) to head (73bb61c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/hooks/useFocusTrap.ts 92.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7879      +/-   ##
==========================================
- Coverage   95.17%   95.13%   -0.05%     
==========================================
  Files         376      377       +1     
  Lines       11041    11051      +10     
  Branches     3664     3669       +5     
==========================================
+ Hits        10508    10513       +5     
- Misses        533      538       +5     
Flag Coverage Δ
unittests 95.13% <92.98%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/vkui/src/hooks/useFocusTrap.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@inomdzhon inomdzhon merged commit 39902ee into master Nov 5, 2024
26 of 28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/useFocusTrap branch November 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants