Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mv useKeyboard to useVirtualKeyboardState #7959

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты
  • Документация фичи

Описание

Переделал логику работы хука (см. описание #6759)

Release notes

Переделал логику работы хука
@inomdzhon inomdzhon self-assigned this Nov 19, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner November 19, 2024 13:26
Copy link
Contributor

size-limit report 📦

Path Size
JS 383.61 KB (+0.45% 🔺)
JS (gzip) 116.28 KB (+0.46% 🔺)
JS (brotli) 95.57 KB (+0.35% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.71 KB (0%)
CSS (gzip) 42.15 KB (0%)
CSS (brotli) 33.24 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 675af8f

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 98.91304% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.31%. Comparing base (792e571) to head (675af8f).
Report is 55 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/lib/dom.tsx 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7959      +/-   ##
==========================================
+ Coverage   95.17%   95.31%   +0.13%     
==========================================
  Files         376      376              
  Lines       11021    11049      +28     
  Branches     3662     3684      +22     
==========================================
+ Hits        10489    10531      +42     
+ Misses        532      518      -14     
Flag Coverage Δ
unittests 95.31% <98.91%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@inomdzhon inomdzhon merged commit f9dc80f into master Nov 20, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/create-useVisualKeyboardState branch November 20, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants