-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useModalRegistry): use useRef #7970
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 7d62012 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7970 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 379 379
Lines 11299 11296 -3
Branches 3764 3764
==========================================
- Hits 10771 10768 -3
Misses 528 528
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
в #6759 удалил этот хук |
|
Unit-тестыe2e-тестыДизайн-ревьюДокументация фичиRelease notesОписание
Хук
useRef
нельзя использовать для чтения или записи во время рендерингаИзменения
Используем useRef по назначению
Release notes