Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Calendar): add prop DoneButton to customize done button #7971

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • Документация фичи
  • Release notes

Описание

Нужно добавить возможность установки кастомной кнопки "Готово" в компоненте Calendar

Изменения

  • Добавил проп DoneButton для компонента Calendar для отрисовки кастомной кнопки

Release notes

Улучшения

  • Calendar: добавлено свойство DoneButton для отрисовки кастомной кнопки "Готово"

    Пример
    <Calendar
      value={value}
      onChange={setValue}
    + DoneButton={(doneButtonProps) => (
    +   <Button {...doneButtonProps} mode="primary" />
    + )}
    />
  • DateInput: добавлено свойство DoneButton для отрисовки кастомной кнопки "Готово"

    Пример
    <DateInput
      value={value}
      onChange={setValue}
    + DoneButton={(doneButtonProps) => (
    +   <Button {...doneButtonProps} mode="primary" />
    + )}
    />

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 21, 2024 10:54
Copy link
Contributor

github-actions bot commented Nov 21, 2024

size-limit report 📦

Path Size
JS 385.6 KB (+0.04% 🔺)
JS (gzip) 116.87 KB (+0.03% 🔺)
JS (brotli) 96.09 KB (+0.06% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.8 KB (0%)
CSS (gzip) 42.35 KB (0%)
CSS (brotli) 33.43 KB (0%)

Copy link

codesandbox-ci bot commented Nov 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 21, 2024

👀 Docs deployed

Commit 2d06f06

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.32%. Comparing base (77fe44d) to head (2d06f06).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7971      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files         379      379              
  Lines       11302    11300       -2     
  Branches     3764     3765       +1     
==========================================
- Hits        10774    10772       -2     
  Misses        528      528              
Flag Coverage Δ
unittests 95.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥
👏

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 29, 2024
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Кастомизация кнопки в Calendar
4 participants