feat(ImageBase): add prop objectPosition #8016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit c51e27f |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8016 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 398 398
Lines 11306 11312 +6
Branches 3734 3737 +3
=======================================
+ Hits 10802 10808 +6
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vkcom-publisher
added
the
pr-needs-work
SevereCloud
previously approved these changes
Dec 10, 2024
…tion # Conflicts: # packages/vkui/src/components/ImageBase/ImageBase.tsx
EldarMuhamethanov
dismissed stale reviews from SevereCloud and andrey-medvedev-vk
via
c51e27f
vkcom-publisher
removed
the
pr-needs-work
andrey-medvedev-vk
approved these changes
Dec 11, 2024
SevereCloud
approved these changes
Dec 11, 2024
EldarMuhamethanov
deleted the
e.muhamethanov/8005/image-base-object-position
branch
BlackySoul
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Нужно добавить свойство
objectPositionдля управления свойствомobject-positionRelease notes
Улучшения
objectPositionдля управления css свойствомobject-position