fix(ModalPage): apply user height for desktop #8036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inomdzhon
added
type:bug
cmp:modal-page
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit aa2c820 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8036 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 393 393
Lines 11192 11158 -34
Branches 3710 3684 -26
=======================================
- Hits 10686 10654 -32
+ Misses 506 504 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
approved these changes
Dec 3, 2024
BlackySoul
approved these changes
Dec 3, 2024
vkcom-publisher
pushed a commit
that referenced
this pull request
Dec 4, 2024
h2. Описание Для **desktop** было зашито `block-size: auto`. Поменял на использование `--vkui_internal_ModalPage--userHeight`, который по умолчанию `auto` для **desktop**. h2. Release notes h2. Исправления - ModalPage: не применялся `height` на **desktop** экране
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Для desktop было зашито
block-size: auto. Поменял на использование--vkui_internal_ModalPage--userHeight, который по умолчаниюautoдля desktop.Release notes
Исправления
heightна desktop экране