feat(Pagination): Add testid for buttons #8038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit c0f0fae |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8038 +/- ##
=======================================
Coverage 95.47% 95.48%
=======================================
Files 393 392 -1
Lines 11188 11153 -35
Branches 3708 3684 -24
=======================================
- Hits 10682 10649 -33
+ Misses 506 504 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrey-medvedev-vk
deleted the
mendrew/Pagination/add-testid-for-buttons
branch
| ✅ v7.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавляем пропы для передачи testid в кнопки страниц и кнопки
next/prev.В
Paginationесть возможность рендерить кнопки кастомно и даже передётсяpage-dataс номером кнопки, но это не то же самое, что иdata-testid. Унифицируем этот момент и добавляем в API.Release notes
Улучшения
pageButtonTestId,prevButtonTestId,nextButtonTestIdдля передачиdata-testidв интерактивные элементы.