fix(HorizontalScroll): fix prevent page scrolling #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
patch
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
e2e tests |
👀 Docs deployed
Commit 8b7971b |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8177 +/- ##
==========================================
- Coverage 95.49% 95.48% -0.01%
==========================================
Files 403 403
Lines 11457 11459 +2
Branches 3783 3786 +3
==========================================
+ Hits 10941 10942 +1
- Misses 516 517 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
inomdzhon
reviewed
Jan 23, 2025
packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
Outdated
Show resolved
Hide resolved
inomdzhon
previously approved these changes
Jan 23, 2025
BlackySoul
reviewed
Jan 24, 2025
packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx
Outdated
Show resolved
Hide resolved
BlackySoul
previously approved these changes
Jan 24, 2025
EldarMuhamethanov
dismissed stale reviews from BlackySoul and inomdzhon
via
8b7971b
inomdzhon
approved these changes
Jan 24, 2025
BlackySoul
approved these changes
Jan 24, 2025
EldarMuhamethanov
deleted the
e.muhamethanov/8176/fix-scroll-on-any-wheel
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Jan 24, 2025
* fix(HorizontalScroll): fix prevent page scrolling * fix(HorizontalScroll): remove useEventListener hook using * fix(HorizontalScroll): fix removeEventListener options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrollOnAnyWheelпропала остановка всплытия событияonwheel#8176Изменения
Перенес подписку события из нативного обработчика в подписку через
addEventListener. Добавил preventDefault события приscrollOnAnyWheelRelease notes
Исправления
onwheelпри прокидыванииscrollOnAnyWheel