Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/history model userstory michiel #176

Merged
merged 31 commits into from
Aug 22, 2023

Conversation

MatthijsBekendam
Copy link
Contributor

No description provided.

@MatthijsBekendam MatthijsBekendam force-pushed the issue/history_model_userstory_michiel branch from 25a3008 to 06f6173 Compare May 25, 2023 09:11
@MatthijsBekendam MatthijsBekendam force-pushed the issue/history_model_userstory_michiel branch from b5748f6 to ae9af2a Compare May 25, 2023 09:33
Copy link
Collaborator

@michielverhoef michielverhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zie in de OAS bij de GET /Zaken retrieve geen query parameter datumGeldigheid.

@MatthijsBekendam MatthijsBekendam force-pushed the issue/history_model_userstory_michiel branch from ba2ff19 to 825b384 Compare May 31, 2023 10:31
@MatthijsBekendam MatthijsBekendam force-pushed the issue/history_model_userstory_michiel branch from 78f6b41 to 8cca3a6 Compare June 5, 2023 07:53
@MatthijsBekendam MatthijsBekendam changed the base branch from master to develop June 12, 2023 08:18
@joerivrij joerivrij dismissed michielverhoef’s stale review August 22, 2023 07:52

this has been implemented as requested.

@MatthijsBekendam MatthijsBekendam merged commit 6718ddd into develop Aug 22, 2023
@MatthijsBekendam MatthijsBekendam deleted the issue/history_model_userstory_michiel branch August 22, 2023 07:58
joerivrij added a commit that referenced this pull request Aug 22, 2023
* feat: Add 'documenten.lezen' and 'zaken.lezen' scopes (#179)

* feat: Add 'documenten.lezen' and 'zaken.lezen' scopes

This commit introduces two new scopes, 'documenten.lezen' and 'zaken.lezen', to the catalogi-api. These scopes inherit the same permissions as the existing 'catalogi.lezen' scope. The addition of these scopes is necessary to accommodate the new expand model, which involves requesting information from the catalogi-api through the documenten-api and zaken-api.

Issue #2262

* Issue/history model userstory michiel (#176)

Implemented and Refactored Features, Bug Fixes, and Formatting Changes:

Added feature in perform_create to automatically add zaaktype relations
Added feature in perform_create to besluittype to add zaaktype relations
Added query parameter "datumGeldigheid" to the GET (retrieve) request
Changed: Moved geldigheid datum validation into the PUBLISH operation from the POST operation
Changed: Updated perform_create for gerelateerde_zaken to create correct relations
Changed: Refactored views and updated openapi documentation
Changed: ZIOT relatie class now uses a char model instead of a foreignfield model for informatieobjecttype
Changed: informatieobjecttype correlates its zaaktype now through a custom serializer
Changed: zaaktype now correlates its informatieobjecttype through a custom serializer
Changed: zaaktype serializer outputs informatieobject URL instead of omschrijvingen
Changed: Disabled notification in base
Changed: post to block creation of two concepts for one zaaktype
Changed: Zaken publish restrictions adapted to the new history model
Fixed: Query parameter in retrieve /zaaktypen gave incorrect dates
Fixed: Unit test using incorrect ZIOT information
Fixed: URL creation in viewsets
Removed: NotificationViewSetMixin from imports
Removed hard-coded strings in extract_relevant_m2m
Updated favicon to VNG logo
--------

* bump version to 1.3.0 (#180)

---------

Co-authored-by: MatthijsBekendam <47739550+MatthijsBekendam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants