Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README.md and 502.html's grammar errors #326

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Fix README.md and 502.html's grammar errors #326

merged 4 commits into from
Sep 12, 2023

Conversation

DuCanhGH
Copy link
Contributor

Description

This PR fixes various grammar errors in README.md and 502.html.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@DuCanhGH DuCanhGH marked this pull request as draft September 12, 2023 17:05
@DuCanhGH
refactor: migrate websocket to ESM
5f163b3 
remove qu

add npm install note in readme

fix reviews

change wording in readme

remove wscat.js

remove config.js

add config.js to gitignore
@DuCanhGH
clean up
1cd9a80
@DuCanhGH
clean up
89b5fc0
@DuCanhGH DuCanhGH marked this pull request as ready for review September 12, 2023 17:27
@hieplpvip hieplpvip merged commit 87c6012 into VNOI-Admin:master Sep 12, 2023
behitek pushed a commit to luyencode/lcoj-site that referenced this pull request Sep 15, 2023
@DuCanhGH @behitek
Fix README.md and 502.html's grammar errors (VNOI-Admin#326)
9c4dd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieplpvip hieplpvip hieplpvip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DuCanhGH @hieplpvip