Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ContestAllProblems #333

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Improve ContestAllProblems #333

merged 3 commits into from
Sep 28, 2023

Conversation

hieplpvip
Copy link
Contributor

Description

Type of change: bug fix, refactor, improvement

What

  • Add cached property is_in_contest and refactor contest views to use it
  • Disable ContestAllProblems access if the contest has ended and problems are not public
  • Improve problem headers in ContestAllProblems

Before:

image

After:

image

Why

:)

How Has This Been Tested?

Locally

Checklist

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@hieplpvip hieplpvip force-pushed the hiep/fix-all-problems branch 2 times, most recently from 41c503e to 3e9dba9 Compare September 24, 2023 10:00
@hieplpvip
ContestMixin: add cached property is_in_contest
b85d898
@hieplpvip
Fix ContestAllProblems access
abada5e 
Previously, private problems can be accessed via ContestAllProblems after contest has ended.
@hieplpvip
Improve problem headers in ContestAllProblems
1b5d170 
- Link to problem detail
- Solved mark
- Translations
@hieplpvip hieplpvip force-pushed the hiep/fix-all-problems branch from 3e9dba9 to 1b5d170 Compare September 28, 2023 05:01
@hieplpvip hieplpvip merged commit dfa261d into master Sep 28, 2023
7 checks passed
@hieplpvip hieplpvip deleted the hiep/fix-all-problems branch September 28, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leduythuccs leduythuccs Awaiting requested review from leduythuccs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hieplpvip