Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper package checks in make_style.sh #335

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

DuCanhGH
Copy link
Contributor

@DuCanhGH DuCanhGH commented Oct 2, 2023

Description

This fixes the package checks in make_style.sh, which were corrupted by my last PR.

How

We simply use a Node.js script to try to import them and quit if they are not available.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@DuCanhGH DuCanhGH changed the title Proper package check in make_style.sh Proper package checks in make_style.sh Oct 2, 2023
@hieplpvip hieplpvip force-pushed the ducanhgh-proper-package-check branch from 24f310f to 8123d1a Compare October 3, 2023 12:56
@hieplpvip hieplpvip merged commit 019edcf into VNOI-Admin:master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants