Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filter bug #340

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix filter bug #340

merged 1 commit into from
Oct 19, 2023

Conversation

winprn
Copy link
Collaborator

@winprn winprn commented Oct 8, 2023

Description

Fix a minor bug when using filter of schools' names that have the same prefix

Type of change: bug fix

What

I changed the selected_orgs to an array of schools' names, instead of a concatenated string

How Has This Been Tested?

  • Select multiple schools
  • Remove schools
  • Clear filter

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@leduythuccs leduythuccs merged commit a2cdd8b into icpc23 Oct 19, 2023
6 of 9 checks passed
@leduythuccs leduythuccs deleted the icpc23-fix-filter branch October 19, 2023 03:51
leduythuccs pushed a commit that referenced this pull request Oct 21, 2023
leduythuccs pushed a commit that referenced this pull request Nov 4, 2023
leduythuccs pushed a commit that referenced this pull request Dec 4, 2023
leduythuccs pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants