Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter by university groups: HSG, Institution, Guest #350

Merged
merged 8 commits into from
Oct 21, 2023

Conversation

winprn
Copy link
Collaborator

@winprn winprn commented Oct 21, 2023

Description

Type of change: new feature

What

What does the PR do?
In addition to filter by school name, users can also filter by group: HSG, Institution, or Guest

How Has This Been Tested?

Tested locally

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

Copy link
Contributor

@leduythuccs leduythuccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :kek:

@leduythuccs leduythuccs merged commit af64ff1 into icpc23 Oct 21, 2023
4 of 6 checks passed
@leduythuccs leduythuccs deleted the icpc23-filter-by-uni-group branch October 21, 2023 19:07
leduythuccs added a commit that referenced this pull request Oct 21, 2023
* add option to filter by university groups: HSG, Institution, Guest

* small fixes

* reduce backend query

* fix error when local storage is empty

* restore submission_related

* Refactor, rename group to tag

* Remove None option, sort

---------

Co-authored-by: winprn <winprn@github.com>
Co-authored-by: Le Duy Thuc <leduythuc.cs@gmail.com>
leduythuccs added a commit that referenced this pull request Nov 4, 2023
* add option to filter by university groups: HSG, Institution, Guest

* small fixes

* reduce backend query

* fix error when local storage is empty

* restore submission_related

* Refactor, rename group to tag

* Remove None option, sort

---------

Co-authored-by: winprn <winprn@github.com>
Co-authored-by: Le Duy Thuc <leduythuc.cs@gmail.com>
leduythuccs added a commit that referenced this pull request Dec 4, 2023
* add option to filter by university groups: HSG, Institution, Guest

* small fixes

* reduce backend query

* fix error when local storage is empty

* restore submission_related

* Refactor, rename group to tag

* Remove None option, sort

---------

Co-authored-by: winprn <winprn@github.com>
Co-authored-by: Le Duy Thuc <leduythuc.cs@gmail.com>
leduythuccs added a commit that referenced this pull request Oct 18, 2024
* add option to filter by university groups: HSG, Institution, Guest

* small fixes

* reduce backend query

* fix error when local storage is empty

* restore submission_related

* Refactor, rename group to tag

* Remove None option, sort

---------

Co-authored-by: winprn <winprn@github.com>
Co-authored-by: Le Duy Thuc <leduythuc.cs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants