Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration of site logo via UI #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magnified103
Copy link
Contributor

Description

Type of change: new feature

What

Site logos can now be configured directly in UI, through misc_config. User-uploaded static files are served under the /static-upload URL prefix.

This PR also imposes unique constraint on the MiscConfig's key field.

How Has This Been Tested?

Tested locally.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

@magnified103 magnified103 force-pushed the change-site-logo-from-ui branch 3 times, most recently from 0fb935b to 65e1cb4 Compare January 14, 2024 15:09
@magnified103 magnified103 force-pushed the change-site-logo-from-ui branch from 65e1cb4 to 763b94c Compare January 29, 2024 11:08
@hieplpvip hieplpvip force-pushed the change-site-logo-from-ui branch from 8d887d5 to 9aa08ff Compare September 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant