VVPPアンインストール時とディレクトリ見つからない時のエラーハンドリング追加 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Dec 16, 2022
| if (!engineInfo) { | ||
| throw new Error(`No such engineInfo registered: engineId == ${engineId}`); | ||
| } | ||
| try { |
There was a problem hiding this comment.
installVvppEngine側はダイアログを出していたがuninstallVvppEngine側はダイアログを出しておらず、エラーが出ても何も表示されない状態になってたので合わせてみました
|
@sevenc-nanashi よかったらレビューお願いできると助かります･･･！ |
sevenc-nanashi
requested changes
Dec 16, 2022
Hiroshiba
commented
Dec 17, 2022
Comment on lines
+831
to
835
| /** | ||
| * VVPPエンジンをアンインストールする。 | ||
| * 関数を呼んだタイミングでアンインストール処理を途中まで行い、アプリ終了時に完遂する。 | ||
| */ | ||
| async function uninstallVvppEngine(engineId: string) { |
There was a problem hiding this comment.
uninstallVvppEngineにドキュメントコメント書いてみました。
| @@ -492,7 +492,6 @@ export default defineComponent({ | |||
| "addingEngine", | |||
| store.dispatch("INSTALL_VVPP_ENGINE", vvppFilePath.value) | |||
| ); | |||
| uiLockedState.value = null; | |||
…リ見つからない時のえらーハンドリング追加
sevenc-nanashi
approved these changes
Dec 17, 2022
|
マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VVPPアンインストール時と、ディレクトリ見つからない時のエラーハンドリング追加しました。
関連 Issue
その他