[project-s] ピアノロールにノートを表示/追加/削除できるようにする #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 4, 2022 22:20
…lay_pianoroll_from_score
romot-co
changed the title
romot-co
force-pushed
the
feature/986_display_pianoroll_from_score
branch
from
9037df4
to
6b8f301
Compare
added 2 commits
January 17, 2023 10:59
|
@Hiroshiba @sigprogramming @y-chan sigさまには先にレビューいただきありがとうございます！ |
romot-co
force-pushed
the
feature/986_display_pianoroll_from_score
branch
from
a624ec2
to
8dcc536
Compare
romot-co
force-pushed
the
feature/986_display_pianoroll_from_score
branch
from
a3bf133
to
df58348
Compare
Co-authored-by: Sig <sigprogrammer@gmail.com>
sigprogramming
approved these changes
Jan 19, 2023
|
@sigprogramming |
|
@Hiroshiba さん、 @y-chan さん、おてすきでレビューお願いいたします…！ |
|
@sigprogramming すみません大変失礼しました！！ 🙇♂️ |
Hiroshiba
approved these changes
Feb 5, 2023
| const gridY = midiKeys; | ||
| const gridX = computed(() => { | ||
| const resolution = store.state.score?.resolution || 480; | ||
| // NOTE: 最低長: 仮32小節...MIDI長さ(曲長さ)が決まっていないため、無限スクロール化する or 最後尾に足した場合は伸びるようにするなど？ |
There was a problem hiding this comment.
無限スクロール化はなかなか腕の見せ所な気がしますね！
理論上は画面上に映ってるものだけを制御できれば良いはずですが、パッと良い実装は思いつきませんでした。。
There was a problem hiding this comment.
@Hiroshiba
こちら再生でスクロール移動などもあるので、virtural scroll化がいいかななどと考えておりますが、
今後考慮できれば…！
|
@Hiroshiba @sigprogramming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue
ref #986
close #986
スクリーンショット・動画など
2023-01-17.18.06.03.mov
その他