コンテキストメニュー表示時の引数の切り分け #1365
Merged
コンテキストメニュー表示時の引数の切り分け #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
今後の機能追加に備え、ユーザー視点の見た目・機能が変わらないように実装を変更
…evox into context-menu-type
Hiroshiba
approved these changes
Jul 2, 2023
|
マージできていなかったのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
OPEN_TEXT_EDIT_CONTEXT_MENU()のような実装をOPEN_CONTEXT_MENU("TEXT_EDIT")のような実装に変更します。テキスト欄上(
"TEXT_EDIT")以外で別のコンテキストメニューを開く機能を追加する準備のためです。内部実装のみの変更のため、ユーザー視点での見た目・機能は変わりません。
関連 Issue/PR
ref #1353
close #1364
上の実装の一部として、下の実装を試みましたが、
考慮部分が多く時間を要しそうなので、ひとまず最初の一歩としてお送りします。