Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for voicevox-browser-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hiroshiba
commented
Jul 18, 2023
| @@ -4,6 +4,7 @@ | |||
| <meta charset="utf-8" /> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | |||
| <meta name="viewport" content="width=device-width,initial-scale=1.0" /> | |||
| <meta name="robots" content="noindex,nofollow"> | |||
There was a problem hiding this comment.
あくまで今のところは開発版なので検索避けです。
将来本番デプロイして検索流入を許容する場合はここを省く必要があります。
Comment on lines
12
to
15
| const router = createRouter({ | ||
| history: isElectron | ||
| ? createWebHashHistory(import.meta.env.BASE_URL) | ||
| : createWebHistory(import.meta.env.BASE_URL), | ||
| history: createWebHashHistory(import.meta.env.BASE_URL), | ||
| routes, | ||
| }); |
There was a problem hiding this comment.
ページにアクセスする時のURLがどういう形になるかの指定です。
元のブラウザ版だと https://host/home にアクセスを想定していて、変更後は https://host/index.html/#/home へのアクセスを想定します。
シングルページアプリケーションの場合はindex.htmlしかできないので /home のアクセスに失敗します。
それ用のリダイレクトやページを作成すればいいのですが、まあまだ本番でプロではないので一旦これでいいかなと思いました。
|
問題ないと思うのでマージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
の解決です。実際にNetlifyを経由してデプロイしています。
https://voicevox-browser-dev.netlify.app/#/home
今はサンプルでこのブランチをデプロイしていますが、後でmainブランチに変えるつもりです。
関連 Issue
fix #1409
スクリーンショット・動画など
その他