Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
commented
Jul 21, 2023
Comment on lines
-55
to
+60
| OS="${{ runner.os }}" | ||
| TARGET="${OS,,}-cpu" # 小文字にする | ||
| OS=$(echo "${{ runner.os }}" | tr "[:upper:]" "[:lower:]") # 小文字にする | ||
| TARGET="$OS-cpu" |
There was a problem hiding this comment.
MacOSで動かなかったので修正
（デフォルトのBashのバージョンが低いらしい）
Hiroshiba
commented
Jul 21, 2023
Comment on lines
-96
to
+100
| cat $TEMPDIR/target.json | jq -r '.tag_name' | sed -e 's_^_version=_' >> $GITHUB_OUTPUT | ||
| echo "version=$(jq -r '.tag_name' $TEMPDIR/target.json)" >> $GITHUB_OUTPUT |
|
マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
下の課題で、linuxやmac環境でe2eテストが動かないことがあることが分かりました。
e2eテストのみは全OSでやった方が良さそうに思ったので、そうするためのプルリクエストです。
関連 Issue
ref #1413
ref #1414
その他
electronやNode.jsが吸収してくれるようなタスクは１環境のみで良さそう。
electronのbackground.tsなどが絡むタスクはそうではないので全環境で回した方が良さそうかなと。