Piniaに部分的に移行する #1443
Open
Piniaに部分的に移行する #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jul 31, 2023
There was a problem hiding this comment.
おーーーー良い感じに思います！！！！！
まだしっかり見れてませんが一旦コメントです！
テスト
Playwrightの自動生成でe2eテスト作ってみませんか･･･！
https://github.com/VOICEVOX/voicevox/tree/a8a5f03d3355321eb7c2cd3baf0d274a48150966#%E3%83%96%E3%83%A9%E3%82%A6%E3%82%B6-end-to-end-%E3%83%86%E3%82%B9%E3%83%88
辞書がエンジン側にステートとして残っちゃうという問題がありますが･･･。
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
|
せっかくだからマージに進めると嬉しいのですが、どこが詰まってたりされますか？ |
|
期末の時期なので試験や課題などで少しさわれていませんでした。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
src/store/dictionary.tsのvuex storeをpiniaに移行します。piniaを入れるにあたってvueのマイナーバージョンを
3.3.4に上げました。関連 Issue
ref #1004
スクリーンショット・動画など
その他
移行するついでにテストを書いていこうかなと思いましたが時間とテスト力が足りませんでした。😔