Refactor: 文字コード系のwriteText関連処理を一箇所にまとめる #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiramisu
commented
Aug 1, 2023
Comment on lines
-1618
to
-1628
|
|
||
| await window.electron | ||
| .writeFile({ | ||
| filePath: filePath.replace(/\.wav$/, ".txt"), | ||
| buffer: await textBlob.arrayBuffer(), | ||
| }) | ||
| .then((result) => { | ||
| if (result.ok) return; | ||
| window.electron.logError(result.error); | ||
| return { result: "WRITE_ERROR", path: filePath }; | ||
| }); |
There was a problem hiding this comment.
返り値をスルーしているのでエラーハンドリングできてなさそうでした。
Comment on lines
-1588
to
-1598
|
|
||
| await window.electron | ||
| .writeFile({ | ||
| filePath: filePath.replace(/\.wav$/, ".lab"), | ||
| buffer: await labBlob.arrayBuffer(), | ||
| }) | ||
| .then((result) => { | ||
| if (result.ok) return; | ||
| window.electron.logError(result.error); | ||
| return { result: "WRITE_ERROR", path: filePath }; | ||
| }); |
There was a problem hiding this comment.
返り値をスルーしているのでエラーハンドリングできてなさそうでした。
Comment on lines
-1719
to
-1728
| await window.electron | ||
| .writeFile({ | ||
| filePath, | ||
| buffer: await textBlob.arrayBuffer(), | ||
| }) | ||
| .then((result) => { | ||
| if (result.ok) return; | ||
| window.electron.logError(result.error); | ||
| return { result: "WRITE_ERROR", path: filePath }; | ||
| }); |
There was a problem hiding this comment.
返り値をスルーしているのでエラーハンドリングできてなさそうでした。
y-chan
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
labファイル・テキストファイルのファイル出力がコピペコードになっているのをaudio.ts先頭にまとめます。
また、encodeをaction内でstateから取得するようにします。
さらに、いくつかエラーハンドリングが上手くいってなさそうだった箇所も修正します。
ユーザー視点での変更はエラーハンドリングの改善以外はありません。