Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

辞書ダイアログのe2eテスト作成 #1467

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

stmtk1
Copy link
Contributor

@stmtk1 stmtk1 commented Aug 3, 2023

内容

辞書ダイアログのe2eテストを作成しました。

関連 Issue

ref #1462

スクリーンショット・動画など

その他

@stmtk1 stmtk1 requested a review from a team as a code owner August 3, 2023 12:30
@stmtk1 stmtk1 requested review from Hiroshiba and removed request for a team August 3, 2023 12:30
@stmtk1
Copy link
Contributor Author

stmtk1 commented Aug 3, 2023

自分のパソコンのスペックの問題かもしれませんが、e2eテストが通らなかったので一部修正しました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!!!

今回はPlaywrightのテスト自動生成機能を使われた感じでしょうか 👀
何か詰まった点とかあったらちょっとご共有いただけると!!

@Hiroshiba Hiroshiba merged commit d0cef91 into VOICEVOX:main Aug 4, 2023
@stmtk1 stmtk1 deleted the e2e-dict branch August 4, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants