Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 上書き防止処理を関数化し共通化 #1478

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Refactor: 上書き防止処理を関数化し共通化 #1478

merged 1 commit into from
Aug 5, 2023

Conversation

thiramisu
Copy link
Contributor

内容

上書き防止のために以下のような処理を行っています。
「こんにちは.wav、こんにちは[1].wavが既に存在していた場合にこんにちは[2].wavに名前を変える」
これが3か所でコピペコードになっているのを、1か所にまとめます。
ユーザー視点での変更はありません。

関連 Issue

ref #1475

スクリーンショット・動画など

その他

@thiramisu thiramisu requested a review from a team as a code owner August 4, 2023 10:37
@thiramisu thiramisu requested review from Hiroshiba and removed request for a team August 4, 2023 10:37
@thiramisu thiramisu mentioned this pull request Aug 4, 2023
Open
26 tasks
Hiroshiba
Hiroshiba approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

長らく共通部分だったところの切り出しファクタリング、大歓迎です･･･！！
ありがとうございます！！！

@Hiroshiba Hiroshiba merged commit 37bd6f9 into VOICEVOX:main Aug 5, 2023
@thiramisu thiramisu deleted the change-tail-to-non-existent-function branch August 5, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiramisu @Hiroshiba