Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

スタイルの"ノーマル"を定数にする #1520

Merged
merged 1 commit into from
Aug 22, 2023
Merged

スタイルの"ノーマル"を定数にする #1520

merged 1 commit into from
Aug 22, 2023

Conversation

thiramisu
Copy link
Contributor

内容

スタイルの"ノーマル"を定数DEFAULT_STYLE_NAMEとして定義します。

関連 Issue

@thiramisu thiramisu requested a review from a team as a code owner August 22, 2023 16:57
@thiramisu thiramisu requested review from Hiroshiba and removed request for a team August 22, 2023 16:57
This was referenced Aug 22, 2023
Merged
Open
Hiroshiba
Hiroshiba approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

ファイル検索で「ノーマル」を調べてみて、しっかり集約されていることを確認しました！！

@Hiroshiba Hiroshiba merged commit d7a674b into VOICEVOX:main Aug 22, 2023
@thiramisu thiramisu deleted the define-default-style-name-2 branch August 22, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiramisu @Hiroshiba