Refactor: audioStates
からnowPlayingAudioKey
を独立させる
#1530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#1525 により、再生中の
audioKey
が高々1つになりました。そのため、
nowPlaying
をaudioKey
ごとに管理する必要がなくなります。これを反映し、
store.state.audioStates[audioKey].nowPlaying
からstore.state.nowPlayingAudioKey
に独立させます。また、それにより
STOP_CONTINUOUSLY_AUDIO
が不要になったので、削除します。STOP_AUDIO
内で諸々の処理が行われていない(ように見える)理由が分かりにくいと感じたので、説明コメントを追加しました。ユーザー視点の変更はありません。
関連 Issue
store/audio.ts
周りのリファクタリング #1475上記の一環です。
audioElements
をRecordから単体にする #1525上記を受けての変更です。
その他