Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GENERATE_AUDIO_KEYをストアの外に出す #1548

Merged
merged 3 commits into from
Sep 14, 2023
Merged

GENERATE_AUDIO_KEYをストアの外に出す #1548

merged 3 commits into from
Sep 14, 2023

Conversation

thiramisu
Copy link
Contributor

内容

#1525 によりGENERATE_AUDIO_KEY内でstateを参照する必要がなくなったため、独立した関数として定義します。
また、その周辺で未使用の戻り値のために複雑になっている実装があったので、解消します。
ユーザー視点での変更はありません。

関連 Issue

その他

@thiramisu thiramisu requested a review from a team as a code owner September 13, 2023 16:52
@thiramisu thiramisu requested review from Hiroshiba and removed request for a team September 13, 2023 16:52
@thiramisu thiramisu mentioned this pull request Sep 13, 2023
Open
26 tasks
Hiroshiba
Hiroshiba approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

分かりやすい差分でした、切り分けありがとうございます！！！

@Hiroshiba Hiroshiba merged commit c2f9ca4 into VOICEVOX:main Sep 14, 2023
@thiramisu thiramisu deleted the separate-generate-audio-key branch September 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiramisu @Hiroshiba