Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildファイルの比較を緩い等価比較に変更 #1679

Merged
merged 1 commit into from
Dec 28, 2023
Merged

buildファイルの比較を緩い等価比較に変更 #1679

merged 1 commit into from
Dec 28, 2023

Conversation

Tksn07
Copy link
Contributor

@Tksn07 Tksn07 commented Dec 27, 2023

内容

↓ こちらのissueによりwarningになっているbuildファイルを修正したPRになります。

関連 Issue

ref #1513

@Tksn07 Tksn07 requested a review from a team as a code owner December 27, 2023 12:49
@Tksn07 Tksn07 requested review from Hiroshiba and removed request for a team December 27, 2023 12:49
Hiroshiba
Hiroshiba approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

進めてくださってありがとうございます！！

@Hiroshiba Hiroshiba merged commit bb4e0b1 into VOICEVOX:main Dec 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tksn07 @Hiroshiba